Feature/cb2 15861 - Investigate how to make changes to defect's that come into effect on a specific date #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that come into effect on a specific date
…id in the dynamodb but could be re-written to be aws AppConfig
NathanielRichards1
changed the title
cb-cs
reviewed
Jan 21, 2025
src/services/DefectsService.ts
Outdated
| @@ -11,22 +13,46 @@ export class DefectsService { | |||
| public getDefectList() { | |||
| return this.defectsDAO | |||
| .getAll() | |||
| .then((data: any) => { | |||
| .then(async (data: any) => { | |||
There was a problem hiding this comment.
Not one to answer here, just making a note for the meeting later.
Is there any chance we can convert this method to using async/await rather than the .then syntax please? Appreciate it's just syntactic sugar but will make it more readable IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigate how to make changes to defect's that come into effect on a specific date
One line description
cb2-15861
Spike work: https://dvsa.atlassian.net/wiki/spaces/HVT/pages/812353458/SPIKE+CB2-15861
15647 implemented around this story only the im9 part
which has the changes for im9 https://dvsa.atlassian.net/browse/CB2-15647
the experimental change date is 2025-03-01.
so before the change date till the start of this year you will get same contents as the file in the draft pull request called:
defect8beforeChange.json
and if you put in a environment variable on the lambda of CURRENT_DATE_OVERRIDE >= 2025-03-01 you should get the same content as the file defect8AfterChange.json.
just to help explain the contents of defect8AfterChange.json.
the changes are on the 5 items:
item 1 stays the same - no change
item 4-5 for defect stays mostly the same but only targets trl now.
item 2-3 become item 2 for hgv and several changes for deficiencies due to the adding of item 2 at the start of item 3.
item 4-5 becomes item 3 for hgv and several changes for deficiencies due to the adding of item 4 at the start of item 5.
lucid link
Checklist