feat(cb2-14764): made recalls nullable as per pr comment

dvsa · Nov 18, 2024 · 1472928 · 1472928
1 parent cddd2e6
commit 1472928
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 4 deletions.
diff --git a/json-definitions/v1/test-result/index.json b/json-definitions/v1/test-result/index.json
@@ -283,6 +283,9 @@
       "anyOf": [
         {
           "$ref": "../recalls/index.json"
+        },
+        {
+          "type": "null"
         }
       ]
     }

diff --git a/types/v1/test-result/index.d.ts b/types/v1/test-result/index.d.ts
@@ -61,7 +61,7 @@ export interface TestResultSchema {
   testHistory?: TestResultSchema[];
   testVersion?: string;
   deletionFlag?: boolean;
-  recalls?: RecallsSchema;
+  recalls?: RecallsSchema | null;
 }
 export interface VehicleClassSchema {
   code: string;

diff --git a/types/v1/test/index.d.ts b/types/v1/test/index.d.ts
@@ -282,7 +282,7 @@ export interface TestResultSchema {
   testHistory?: TestResultSchema[];
   testVersion?: string;
   deletionFlag?: boolean;
-  recalls?: RecallsSchema;
+  recalls?: RecallsSchema | null;
 }
 export interface TestTypeSchema {
   testTypeName: string | null;

diff --git a/types/v1/vehicle/index.d.ts b/types/v1/vehicle/index.d.ts
@@ -274,7 +274,7 @@ export interface TestResultSchema {
   testHistory?: TestResultSchema[];
   testVersion?: string;
   deletionFlag?: boolean;
-  recalls?: RecallsSchema;
+  recalls?: RecallsSchema | null;
 }
 export interface TestTypeSchema {
   testTypeName: string | null;

diff --git a/types/v1/visit/index.d.ts b/types/v1/visit/index.d.ts
@@ -295,7 +295,7 @@ export interface TestResultSchema {
   testHistory?: TestResultSchema[];
   testVersion?: string;
   deletionFlag?: boolean;
-  recalls?: RecallsSchema;
+  recalls?: RecallsSchema | null;
 }
 export interface TestTypeSchema {
   testTypeName: string | null;
-Original file line number
+Diff line change
@@ Expand Up / @@ -283,6 +283,9 @@ @@
           "anyOf": [
             {
               "$ref": "../recalls/index.json"
+            },
+            {
+              "type": "null"
             }
           ]
         }
@@ Expand Down @@