Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create basic java amazoncorretto 8 image #59

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: Create basic java amazoncorretto 8 image #59

wants to merge 4 commits into from

Conversation

lchlipala
Copy link

@lchlipala lchlipala commented Feb 10, 2025 •
edited
Loading

Description

Related issue: BL-18567

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@lchlipala lchlipala force-pushed the feature-BL-18567-create-java-base-image branch 3 times, most recently from 41ef267 to f7ab324 Compare February 11, 2025 09:28
@lchlipala lchlipala marked this pull request as draft February 12, 2025 10:06
@lchlipala lchlipala marked this pull request as ready for review February 12, 2025 13:42
@lchlipala lchlipala force-pushed the feature-BL-18567-create-java-base-image branch from d3580cc to 0649720 Compare February 12, 2025 14:07
@lchlipala lchlipala force-pushed the feature-BL-18567-create-java-base-image branch from 0649720 to 61c9063 Compare February 13, 2025 11:55
n-r-b
n-r-b approved these changes Feb 13, 2025
View reviewed changes
Copy link

@n-r-b n-r-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lukasz has successfully managed to get the Vehicle Service running using this image in his local environment.

@lchlipala lchlipala force-pushed the feature-BL-18567-create-java-base-image branch 2 times, most recently from d038b40 to 48f5782 Compare February 13, 2025 14:27
@lchlipala lchlipala force-pushed the feature-BL-18567-create-java-base-image branch from 48f5782 to 8278996 Compare February 18, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mg-bjss mg-bjss mg-bjss left review comments

@n-r-b n-r-b n-r-b approved these changes

@ccurran01 ccurran01 ccurran01 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lchlipala @n-r-b @ccurran01 @mg-bjss