parallel_embeddings.py and feasibility.py minor corrections #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kevin Chern <[email protected]> Co-authored-by: Jack Raymond <[email protected]> Co-authored-by: Theodor Isacsson <[email protected]> Co-authored-by: Kelly Boothby <[email protected]>
…asibility to parallel_embeddings
jackraymond
added a commit
to AndyZzzZzzZzz/shimming-tutorial
that referenced
this pull request
Dec 27, 2024
…. Minor refactor
randomir
reviewed
Jan 6, 2025
randomir
reviewed
Jan 6, 2025
| @@ -128,7 +128,7 @@ def find_multiple_embeddings( | |||
| S: The source graph to embed. | |||
| T: The target graph in which to embed. | |||
| max_num_emb: Maximum number of embeddings to find. | |||
| Defaults to 1, set to float('Inf') to find the maximum possible | |||
| Defaults to 1, set to None to find the maximum possible | |||
There was a problem hiding this comment.
This is actually a breaking change. For backwards compatibility, consider supporting inf as well, but throwing a deprecation warning if called with it. (I haven't checked, but if Inf support hasn't been released yet, than no need to deprecate it, obviously.)
There was a problem hiding this comment.
Indeed, this code hasn't been released yet, so please ignore the comment above.
There was a problem hiding this comment.
The first pull request was merged prematurely. I think @thisac wants to take a second look at this tidy up request as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor improvements to new parallel_embeddings.py and feasibility.py modules: