Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling Options correctly #90

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Handling Options correctly #90

merged 1 commit into from
Feb 22, 2024

Conversation

kukoc
Copy link
Contributor

@kukoc kukoc commented Feb 22, 2024

So far we were assuming that options were embedded in a HalResource Response, but users can also fetch them by sending an Options call.

dsingh45
dsingh45 approved these changes Feb 22, 2024
View reviewed changes
Copy link

@dsingh45 dsingh45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this enhancement

@Jialecl Jialecl merged commit c421dc4 into master Feb 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsingh45 dsingh45 dsingh45 approved these changes

@Jialecl Jialecl Jialecl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kukoc @dsingh45 @Jialecl