Add a plugin generator #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobjS
requested changes
Sep 18, 2023
There was a problem hiding this comment.
@snim2 This generally looks sensible to me, but there are a few undeclared properties used that will generate errors in PHP 8.2. Maybe it'd be worth having unit tests for this class so those would be picked up in CI?
I've realised this will also apply to some of the existing classes that don't have test coverage, so I've opened an issue for that: #221
| private $unique_temp_id; | ||
|
|
||
| function __construct($options) { | ||
| $this->options = $options; |
There was a problem hiding this comment.
As a dynamic property, this will generate errors in PHP 8.2
| $this->options = $options; | ||
|
|
||
| if(isset($this->options->directory)) { | ||
| $this->target_dir = getcwd() . '/' . $this->options->directory; |
There was a problem hiding this comment.
$target_dir will also need declaring as a property for PHP 8.2
Fixes #162 Add a new generator to clone code in our WordPress plugin repo: https://github.com/dxw/wordpress-plugin-template
This is to avoid errors in PHP8.x.
snim2
force-pushed
the
feature/generate-plugin
branch
from
a65cb3c to
5f083e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new generator to clone code in our WordPress plugin repo:
https://github.com/dxw/wordpress-plugin-template
Resolves: #162
Testing
Run
whippet generate pluginand maybe try the relevant options, e.g.--nogitignore