Do not specify PHP version in root composer #162
Conversation
|
I've looked into this a bit more, and I don't think specifying the PHP version in this file is actually as problematic as I first thought - there are plenty of repo's where the version is set to 8.2 and the automated workflows (set to run in 7.4) still complete successfully, because the latest version of Whippet works in both. And even though it doesn't really do anything, it does serve as some kind of useful marker as to whether a repo should be on PHP 7 or 8. So now I'm thinking maybe we should: |
|
@RobjS sure. I'd change davids first, just to validate anything that goes into the template |
Although this won't have any effect on the PHP version the app runs on (it just determines the version used to install Whippet), it's a useful indicator of what version we're using in the app, and it should be consistent with that.
RobjS
force-pushed
the
chore/do-not-specify-php-version-in-root-composer
branch
from
ba23b91 to
a3218c5
Compare
The intention of the root composer file is just to ensure that Whippet is available for use in local development (or in automated workflows) without needing to be globally installed.
Any PHP version specified here neither indicates what PHP version the app is intended to run on (as none of the dependencies here are used in deployed code), nor should affect the output of any Whippet commands run.
So, for maximum compatibility as we're in the midst of the PHP7-to-8 switchover, let's not indicate a PHP version here at all.