Chore/update docker network #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snim2
force-pushed
the
chore/update-docker-network
branch
from
e729bf3 to
e033078
Compare
We don't deploy Beanstalk anywhere now, and very few sites run the replacement service (SQS), so it makes sense just to remove this.
We currently deploy new sites with PHP 8.3 and develop with 8.2, so for now it makes sense to have 8.2 as the default version of PHP in our template.
snim2
force-pushed
the
chore/update-docker-network
branch
from
e033078 to
99649f0
Compare
matthewpassmore
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
versiondirective fromdocker-compose.ymlDesign notes
Note that I haven't made much effort to update the theme here because we don't really use it any more. In the longer term I'm wondering if we should swap that out for the govuk-theme.
Steps for testing
./script/setup./script/server