Skip to content

Commit

Permalink
fix: duplicate v4-proto dep into devDep (#245)
Browse files Browse the repository at this point in the history
Was running into an issue where everytime I tried to commit with an
updated v4-clients, I got
```Cannot find module '@dydxprotocol/v4-proto/...``` 

Figured out from [here](https://dev.to/jody/a-tip-on-using-peer-dependencies-with-typescript-2bji) that this is expected from moving proto into peerDependencies. Managed to get things working (using jeremy's nifty lil local install script) by duplicating into `devDependencies` which I think should be adequate (as opposed to moving it into `dependencies` but someone lmk if I'm wrong
  • Loading branch information
moo-onthelawn authored Sep 18, 2024
1 parent ddc0b00 commit 660c306
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions v4-client-js/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
"@commitlint/cli": "^19.5.0",
"@commitlint/config-conventional": "^19.5.0",
"@dydxprotocol/node-service-base-dev": "^0.2.6",
"@dydxprotocol/v4-proto": "6.0.1",
"@protobufs/cosmos": "^0.0.11",
"@protobufs/gogoproto": "^0.0.10",
"@semantic-release/changelog": "^6.0.3",
Expand Down

0 comments on commit 660c306

Please sign in to comment.