fix(bonsai-core): Orderbook Grouping and fix in depth calculations #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jaredvu
commented
Jan 28, 2025
jaredvu
commented
- Updated so now we sort Asks by ascending and bids by descending from one function. No other orderbook function should reverse this and in conclusion, should handle asks vs bids differently.
- Fixed pop vs shift: previously saved the popped or shifted element instead of the next array item
- Handle grouping calculations
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tyleroooo
reviewed
Jan 28, 2025
tyleroooo
reviewed
Jan 28, 2025
| @@ -182,7 +180,7 @@ interface BonsaiHelpersShape { | |||
| fills: BasicSelector<SubaccountFill[]>; | |||
| }; | |||
| orderbook: { | |||
| data: BasicSelector<OrderbookProcessedData | undefined>; | |||
There was a problem hiding this comment.
alternative: store grouping in the state somewhere and then these can be normal selectors
tyleroooo
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.