Support Python 3.12+ as well as switching to the latest pint #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In python 3.12 these are now Syntax Errors instead of Deprecation warnings.
…that come with pint.
…a unify dash.
The tests previously weren't working correctly. Specifically when doing Quantity('-123') with a unify dash, pint would actually return the Quantity('123'). The test doesn't catch this, as the test is effectively doing Quantity($input) == Quantity($input).
With Python 3.12, the internals of Quantity changed, to explictly reject unify dashes, instead of silently skipping them.
In pint 0.21 ppm was officially added, named ppm, instead of parts_per_million.
dylanwal
approved these changes
Jul 5, 2024
bramp
commented
Jul 5, 2024
| @@ -10,7 +10,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| python-version: ["3.7", "3.10", "3.11"] | |||
| python-version: ["3.8", "3.10", "3.11"] | |||
There was a problem hiding this comment.
Should 3.12 be added to the list?
There was a problem hiding this comment.
Yes, I will add it to a new PR that I have coming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unit_parse did not work with Python 3.12 (due to #9 / hgrecco/pint#1974), which required bumping to the latest version of Pint.
I made appropriate changes, and ensured all tests continue to pass.
Fixes #9