feat(observe api): seperate c++ bindings from c bindings #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we move the component stuff out of here now that we've provided it to the community in wasi-observe? Seems like its fallen behind tooling and causing CI to fail. |
I'd be happy to nuke the observe component support as I don't think anyone uses it and fixing it up, is probably just as much work as readding it, as I'm sure there's been tooling changes. If we have a need for it or someone contributes it, we could always readd it. @chrisdickinson What do you think? |
|
Yeah, probably worth ripping that out for now. Git will remember it for us if we ever need it in the future! |
G4Vi
force-pushed
the
feat-seperate-cxx-bindings
branch
from
7582eb6
to
688525f
Compare
nilslice
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using the c++ bindings without the c bindings. Making the C++ bindings easier to use also a single header library. In a C++ project both bindings still may be used all the time.