Skip to content

Commit

Permalink
improve logging
Browse files Browse the repository at this point in the history
  • Loading branch information
zale144 committed Feb 14, 2025
1 parent 8613199 commit acb7457
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 24 deletions.
16 changes: 9 additions & 7 deletions eibc/order_eventer.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package eibc
import (
"context"
"fmt"
"slices"
"strconv"
"time"

Expand Down Expand Up @@ -73,15 +74,16 @@ func (e *orderEventer) enqueueEventOrders(_ context.Context, eventName string, r
}
e.orderTracker.trackOrders(orders...)

if e.logger.Level() <= zap.DebugLevel {
ids := make([]string, 0, len(orders))
for _, order := range orders {
ids = append(ids, order.id)
rollaps := make([]string, 0, len(orders))
ids := make([]string, 0, len(orders))
for _, order := range orders {
ids = append(ids, order.id)
if slices.Contains(rollaps, order.rollappId) {
continue
}
e.logger.Debug(fmt.Sprintf("%s demand orders", d), zap.Strings("ids", ids))
} else {
e.logger.Info(fmt.Sprintf("%s demand orders", d), zap.Int("count", len(orders)))
rollaps = append(rollaps, order.rollappId)
}
e.logger.Info(fmt.Sprintf("%s demand orders", d), zap.Strings("ids", ids), zap.Strings("rollapps", rollaps))

return nil
}
Expand Down
26 changes: 9 additions & 17 deletions eibc/order_poller.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"encoding/json"
"fmt"
"net/http"
"slices"
"sort"
"strconv"
"strings"
Expand Down Expand Up @@ -127,15 +128,14 @@ func (p *orderPoller) pollPendingDemandOrders(ctx context.Context) error {
return nil
}

// if p.logger.Level() <= zap.DebugLevel {
// ids := make([]string, 0, len(newOrders))
// for _, order := range newOrders {
// ids = append(ids, order.id)
// }
// p.logger.Debug("new demand orders", zap.Strings("ids", ids))
// } else {
p.logger.Info("new demand orders", zap.Int("count", len(newOrders)))
// }
rollaps := make([]string, 0, len(newOrders))
for _, order := range newOrders {
if slices.Contains(rollaps, order.rollappId) {
continue
}
rollaps = append(rollaps, order.rollappId)
}
p.logger.Info("new demand orders", zap.Int("count", len(newOrders)), zap.Strings("rollapps", rollaps))

p.orderTracker.trackOrders(newOrders...)

Expand Down Expand Up @@ -233,10 +233,6 @@ func (p *orderPoller) getDemandOrdersFromIndexer(ctx context.Context) ([]Order,
demandOrders = append(demandOrders, orders...)
}

if len(demandOrders) > 0 {
p.logger.Debug("got demand orders", zap.Int("count", len(demandOrders)))
}

return demandOrders, nil
}

Expand Down Expand Up @@ -270,10 +266,6 @@ func (p *orderPoller) getDemandOrdersFromRPC(ctx context.Context) ([]Order, erro
orders = append(orders, order)
}

if len(orders) > 0 {
p.logger.Debug("got demand orders", zap.Int("count", len(orders)))
}

return orders, nil
}

Expand Down

0 comments on commit acb7457

Please sign in to comment.