Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to new operator & fixes #16

Merged
merged 7 commits into from
Oct 30, 2023
Merged

Migrate to new operator & fixes #16

merged 7 commits into from
Oct 30, 2023

Conversation

joushx
Copy link
Contributor

@joushx joushx commented Oct 17, 2023

  • Migrate to new Dynatrace operator (deploy operator, DynaKube needs to be created manually)
  • Remove secret handling, update example and add DynaKube reference in README
  • Regenerate addon folder from cdk CLI to get current best practices

@dynatrace-cla-bot
Copy link
Member

dynatrace-cla-bot commented Oct 17, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@arthfl arthfl requested a review from heckelmann October 17, 2023 08:45
heckelmann
heckelmann reviewed Oct 17, 2023
View reviewed changes
README.md Show resolved Hide resolved
@heckelmann
Copy link
Collaborator

  • Migrate to new Dynatrace operator (deploy operator, DynaKube needs to be created manually)
  • Remove secret handling, update example and add DynaKube reference in README
  • Regenerate addon folder from cdk CLI to get current best practices

I wonder if the whole DT EKS Addon is needed at all, as the only thing the module is doing is installing a helm chart, which could be achieved by using the HelmAddon on its own. WDYT?

heckelmann
heckelmann approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@heckelmann heckelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lhtm

@heckelmann heckelmann merged commit 633d054 into main Oct 30, 2023
3 of 5 checks passed
@joushx joushx deleted the fix-outdated-custom-resource branch January 11, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heckelmann heckelmann heckelmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joushx @dynatrace-cla-bot @heckelmann @arthfl @jm-dt