Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap MD5 hash to CRC32 for checksum calculation #39

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Swap MD5 hash to CRC32 for checksum calculation #39

merged 4 commits into from
Jan 28, 2025

Conversation

pirgeo
Copy link
Member

@pirgeo pirgeo commented Jan 17, 2025

For this use-case, use of a cryptographic hash function is not required. File contents are being hashed and compared to identify whether a change in the file occurred.

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just one comment I'm not sure about.

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thank you 🙂

@pirgeo pirgeo merged commit 45f8872 into main Jan 28, 2025
13 checks passed
@pirgeo pirgeo deleted the use-crc32 branch January 28, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants