Fix checking whether source address in X-Forwarded-For is ipv4 or ipv6 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hparzych
force-pushed
the
fix/handling-mismatch-x-forwarded-for-src-addr
branch
2 times, most recently
from
f88b73d to
b5092fd
Compare
przsus
previously approved these changes
Jan 29, 2024
hparzych
force-pushed
the
fix/handling-mismatch-x-forwarded-for-src-addr
branch
from
b5092fd to
09df500
Compare
hparzych
force-pushed
the
fix/handling-mismatch-x-forwarded-for-src-addr
branch
from
09df500 to
368bb5f
Compare
przsus
reviewed
Jan 30, 2024
|
|
przsus
reviewed
Feb 1, 2024
filip-szweda
reviewed
Feb 2, 2024
| } | ||
| return ipChecker.isV6AddressExternal(clientAddrBinary); | ||
| } | ||
|
|
||
| static bool isClientExternal(const IpAddressChecker& ipChecker, const std::string& addr, bool isIpV6) { | ||
| return isIpV6 ? isIpv6ClientExternal(ipChecker, addr) : isIpv4ClientExternal(ipChecker, addr); | ||
| static bool isClientExternal(const IpAddressChecker& ipChecker, const std::string& addr, bool isIpv6) { |
There was a problem hiding this comment.
Suggested change
| static bool isClientExternal(const IpAddressChecker& ipChecker, const std::string& addr, bool isIpv6) { | |
| static bool isClientExternal(const IpAddressChecker& ipChecker, const std::string& addr, bool isPossiblyIpv6) { |
| } | ||
|
|
||
| static bool isClientExternal(const IpAddressChecker& ipChecker, const std::string& addr) { | ||
| bool isPossiblyIpv6{std::count(addr.begin(), addr.end(), ':') >= 2}; |
There was a problem hiding this comment.
I think that Ipv6-checking logic should not be hidden inside a isClientExternal wrapper and should rather be called outside isClientExternal.
hparzych
added a commit
that referenced
this pull request
Apr 26, 2024
hparzych
added a commit
that referenced
this pull request
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.