-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci tools documentation updates #12
base: master
Are you sure you want to change the base?
Ci tools documentation updates #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR but I'm not sure whether It's a good idea to bind so tightly build system with minikube on docker container driver and devspace which we don't use. Isn't it overengineering?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Paweł. We shouldn't bind the builds to minikube and devspace.
Regarding pushing images, I'll contact the relevant people and let you know how it could be solved.
Probably I didn't explained properly. Minikube and devspace are only used for local development and testing purposes, imitating Kubernetes cluster. Github actions building, tagging, and pushing image into docker hub. |
Hi @AugustasV , That could be achieved by sticking to the changes in c-cpp.yml (except logging in to Docker Hub and push: true) and saving other changes for later. I'll try to establish how we should handle images as soon as possible. |
Sure @pijuszczyk I could do that, or maybe we should go different approach? I could use Github Packages to save Docker images here on Github. It's free for public repos https://github.com/features/packages#pricing |
Thanks for the suggestion, we could use that. However, still first I'd need to discuss this topic. I think a conclusion could be reached sometime next week. If you don't mind waiting a little longer I'll reach you then about what can be done in this case. But if you prefer to close the pull request sooner, I'd recommend stashing the changes like I described above. |
Added GitHub action that would push the image into the docker hub. Right now it is configured to trigger only the master branch. Configuration is made into my docker hub account, probably would be better to switch to Github Packages?
Also wrote documentation on how to spin up local Kubernetes cluster and test things locally using DevSpace. Small README improvements.
Looking for a feedback on how to improve this PR.
Not possible to add as a reviewer, so tagging like that @pijuszczyk @pawsten