Add default AWS LB annotations #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MfCrizz
force-pushed
the
feature/add-default-aws-annotations
branch
from
4cbfcaf
to
bb1ca58
Compare
MfCrizz
changed the title
W3D3
requested changes
Nov 15, 2023
MfCrizz
force-pushed
the
feature/add-default-aws-annotations
branch
3 times, most recently
from
f13cad6
to
fe12b4b
Compare
|
Shouldn't the docs also mention that one needs to install the AWS Load Balancer Controller. Novices might be confused why nothing will happen otherwise. I don't mean to explain everything step-by-step, but putting a link to the documentation wouldn't hurt: https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.6/ |
MfCrizz
force-pushed
the
feature/add-default-aws-annotations
branch
from
fe12b4b
to
5416905
Compare
W3D3
reviewed
Nov 17, 2023
W3D3
reviewed
Nov 17, 2023
W3D3
approved these changes
Nov 17, 2023
MfCrizz
force-pushed
the
feature/add-default-aws-annotations
branch
from
7715357
to
cae6d4b
Compare
MfCrizz
force-pushed
the
feature/add-default-aws-annotations
branch
from
cae6d4b
to
d87f79a
Compare
W3D3
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds default AWS Load Balancer annotations.
Now only the
aws.enabledvalue needs to be set true and the ingress will be configured with save default annotations.Also add AWS installation section to Chart readme.