🐘 Add like-service (PHP) for liking/unliking posts #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
eliasgierlinger
force-pushed
the
main_php
branch
from
d3725f0
to
530d845
Compare
|
[ISSUE] The like counter has a serif font, which is not used anywhere else, please change it to the same font that is used everywhere else. Also the whole like element is way too big IMO. |
W3D3
reviewed
Oct 24, 2023
W3D3
requested changes
Oct 24, 2023
src/microblog-service/src/main/java/org/dynatrace/microblog/dto/Post.java
Outdated
Show resolved
Hide resolved
W3D3
requested changes
Nov 7, 2023
W3D3
approved these changes
Nov 20, 2023
exploit-toolkit/exploits/sql-injection/SQLI-LIKE-SERVICE-REMOVE-LIKE.md
Outdated
Show resolved
Hide resolved
eliasgierlinger
force-pushed
the
main_php
branch
2 times, most recently
from
0b6b3a5
to
dc32b1e
Compare
AlejandroCamba
approved these changes
Nov 20, 2023
|
Pls rebase on |
…exploitable through frontend
eliasgierlinger
force-pushed
the
main_php
branch
from
dc32b1e
to
fb332cc
Compare
|
@W3D3 I rebased; you should be able to merge it now 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
like-serviceuses Laravel, a PHP framework, in a version that is vulnerable to a certain kind of SQL Injection (see Snyk entry) and that is recognized as a Third Party Vulnerability.Posts on the frontend now have a like symbol in the bottom right corner, which you can use to like or unlike the post. The Laravel vulnerability allows you to remove another user's like (described in more detail in exploit-toolkit/exploits/sql-injection/SQLI-LIKE-SERVICE-REMOVE-LIKE.md).
The
microblog-servicehad to be updated to send a post ID when you request posts in order to allow the frontend and like-service to uniquely identify posts.The user-simulator, malicious-load-generator, and exploit-toolkit were also updated.
Some updates had to be made to the way Jaeger is used. Whereas most services communicate with Jaeger via a
jaeger-agent, the PHP OpenTelemetry extension can only communicate with thejaeger-collector. However, to get thejaeger-collectorto accept OpenTelemetry traces, a config file (chart/jaeger-otlp-values.yaml) needs to be passed when installing jaeger, as described in docs/TRACING.md.Most of the new files in
src/like-servicewere auto-generated as part of a template. Some of the main files of interest are:routes/web.php: Route definitionsapp/Http/Controllers/LikeController.php: Handling of the routesconfig/database.php: Database credentialsapp/Console/Commands/CreateDatabase.php: Database creationdatabase/migrations/2023_07_13_073935_create_like_table.php: Table creation (yes, the name has to contain a timestamp)public/index.php: Initialization code for tracing (OpenTelemetry/Jaeger)app/Http/Controllers/JaegerPropagator.php: Special "propagator" code that is needed for PHP OpenTelemetry to interface with Jaeger