Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/change membership service to adhere to known agent limitations #74

Merged
merged 3 commits into from
May 14, 2024
Merged

Feature/change membership service to adhere to known agent limitations #74

merged 3 commits into from
May 14, 2024

Conversation

orazefabian
Copy link
Contributor

This PR changes the MembershipService to adhere to the known limitations of the agent:

  1. Usage of the EntityFramwork is discarded - the service now uses plain ADO .NET
  2. The request data is not sent as json via the request body, but rather as form parameters using the contenty type: application/x-www-form-urlencoded

@orazefabian orazefabian requested a review from a team as a code owner May 10, 2024 09:15
@dynatrace-cla-bot
Copy link
Member

dynatrace-cla-bot commented May 10, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@orazefabian orazefabian force-pushed the feature/change-membership-service-to-adhere-to-known-agent-limitations branch 4 times, most recently from 5cf0513 to 6e22a44 Compare May 13, 2024 14:07
W3D3
W3D3 approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@W3D3 W3D3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor things. Fine to merge IMO.

@orazefabian orazefabian force-pushed the feature/change-membership-service-to-adhere-to-known-agent-limitations branch from b1e30e7 to 60b076b Compare May 14, 2024 07:54
@orazefabian orazefabian force-pushed the feature/change-membership-service-to-adhere-to-known-agent-limitations branch from 60b076b to 192b1ae Compare May 14, 2024 08:08
@orazefabian orazefabian merged commit b2e48f6 into main May 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W3D3 W3D3 W3D3 approved these changes

Assignees

@orazefabian orazefabian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orazefabian @dynatrace-cla-bot @W3D3