Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/noissue/improve contribution guidelines #75

Merged
merged 2 commits into from
May 13, 2024
Merged

Feature/noissue/improve contribution guidelines #75

merged 2 commits into from
May 13, 2024

Conversation

orazefabian
Copy link
Contributor

This PR adds the following:

  • Adds pre-commit hook to check for the correct commit style format before committing

2024-05-10_11-31

  • Adds commit style documentation to our contribution guidelines

@sassko
🧑‍💻 refactor(npm): Add pre-commit hook that validates commit style
d078279 
 The validation uses the same configuration as the one used in our github action to make sure what works locally will work remotely.
@sassko
📝 docs(contributing): Add commit style guidelines
f1fe130
@orazefabian orazefabian requested a review from a team as a code owner May 10, 2024 09:36
@orazefabian
Copy link
Contributor Author

Checked it out, pre-commit hook works as expected and the updated contribution guidelines look good 👍🏼

W3D3
W3D3 approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@W3D3 W3D3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orazefabian orazefabian merged commit 0b30afd into main May 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W3D3 W3D3 W3D3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orazefabian @W3D3 @sassko