Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(payment-service): Adds new payment service written in Python #80

Merged
merged 8 commits into from
Jul 22, 2024

Conversation

orazefabian
Copy link
Contributor

Description

This PR adds a payment service to Unguard.
The service is written in Python 3.8.0 using Flask for the REST API and poetry for dependency management.

Changes:

  • Adds a new page to the frontend where a user can enter a credit card
  • Adds the python service
  • Updates configuration files for skaffold and helm
  • Adds tracing with opentelementry for new service
  • Updates user-simulator to act upon new payment service page
  • Updates documentation

Screenshot

payment-service

@orazefabian orazefabian requested a review from a team as a code owner July 16, 2024 07:59
@orazefabian orazefabian force-pushed the feature/add-vulnerable-python-service branch from 1048721 to 405c407 Compare July 16, 2024 08:12
@orazefabian orazefabian changed the title 🔧 feat(payment-service): Adds new payment service 🔧 feat(payment-service): Adds new payment service written in Python Jul 16, 2024
src/payment-service/README.md Outdated Show resolved Hide resolved
src/payment-service/README.md Show resolved Hide resolved
docs/TRACING.md Show resolved Hide resolved
src/frontend/site.js Show resolved Hide resolved
src/frontend/site.js Show resolved Hide resolved
src/frontend/site.js Show resolved Hide resolved
src/payment-service/README.md Show resolved Hide resolved
src/payment-service/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@W3D3 W3D3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things need to be fixed still, but looks good overall.

@W3D3
Copy link
Contributor

W3D3 commented Jul 17, 2024

Another tiny NIT, your commit message should use sparkles (✨) instead of the wrench to indicate a new feature:
https://gist.github.com/parmentf/035de27d6ed1dce0b36a

@orazefabian orazefabian force-pushed the feature/add-vulnerable-python-service branch from 405c407 to bbfa854 Compare July 18, 2024 11:23
@orazefabian orazefabian changed the title 🔧 feat(payment-service): Adds new payment service written in Python ✨ feat(payment-service): Adds new payment service written in Python Jul 18, 2024
src/payment-service/README.md Outdated Show resolved Hide resolved
chart/values.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@W3D3 W3D3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor things could be improved.

@orazefabian orazefabian self-assigned this Jul 19, 2024
@orazefabian orazefabian force-pushed the feature/add-vulnerable-python-service branch from 03a16cc to 769463c Compare July 22, 2024 07:44
@orazefabian orazefabian merged commit c5bcf29 into main Jul 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants