Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(chart): Add labels.common helm value to easily put labels on all resources #91

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

W3D3
Copy link
Contributor

@W3D3 W3D3 commented Oct 22, 2024

This PR adds the labels.common helm value that takes a list of labels that will be applied to all Kubernetes resources deployed with Unguard, also including pods.

Tried it out locally, works both with multiple labels, as well as none.

See:
image

@W3D3 W3D3 requested a review from a team as a code owner October 22, 2024 11:47
Copy link
Contributor

@sassko sassko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly 👍

@W3D3 W3D3 force-pushed the feature/add-common-labels-via-values branch from 9c68f3c to f122340 Compare October 23, 2024 12:48
@W3D3 W3D3 merged commit 283e34b into main Oct 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants