With the help of Sarbian, I applied his diff from a binary KortexM had created #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a593d85.
* Recompiled for KSP 1.3.1. * Added compatibility for FilterExtensions to all parts. * Added the ability to toggle the fairing side decoupler (no more separate "Fairing" and "Fuselage" sides). * The base and nose shapes of fairing sides can now be changed in the editor (no more separate part configs for different fairing shapes). * Repackaged the distribution for the components to be on their own directories. * Changed the versioning system to use a <KSP Version>-<Release Number> format. * Updated the part configs for compatibility with the latest KSP versions. * Reorganized the repository. * Added a .gitattributes file. * Added a missing Github license file. * Updated the Github readme file.
* The base curve can now be edited like the nose curve. * Added an option to change the number of segments that the fairing is comprised (both base and nose). * Reshuffled the GUI elements a bit to make handling a bit easier. * Reverted the fairing side part name for compatibility with various mods that use MM to clone and edit the baseline fairing part.
* Save-breaking update! * Re-export all part models and textures to allow easier texture switching (KSP 1.4+). * Add support for normal maps to the fairing side model. * Add/fix some missing decoupler FX and sound definitions. * Add decoupler modules to the fairing bases and interstages (can be toggled via the PAW). * Make the fairing side invisible when hovering the cursor above it. * Add a MM patch to convert the stock fairing bases to PF ones.
* Re-export the fairing and fuselage textures for better compatibility with the fairing transparency feature.
* All fairing sides will now update their new properties at the same time (fairing decouplers are still WIP).
* The FS texture switching ideally will be replaced by the KSP 1.4 texture switcher. * Update the standard fairing textures to support texture switching. * Update some configs to not apply when PFFE is installed.
* The fairing base and nose tweakables are now hidden by default.
* Now compatible (again...) with MM-cloned fairing sides. * Back to using two distinct fairing side shapes (easier to use by default - shape changes should be optional). * Fairing sides now have the same staging icon as the stock procedural fairings.
* This allows the fairing to be reset back to it's default shape options when the base/nose auto-shape button is enabled. * Also fix the wrong button GUI states after loading an existing craft file.
* Not needed anymore.
* Reformat the changelog headers. * Update the PF side titles for better grouping. * Use the new part config parameter to hide the extra stock fairing bases.
* Manually handle the model setup. * Tag the part as procedural. * Remove the useless part variants. * Fix the rest of the fairings to properly hide (TechHidden does not hide them from the editors you stupid...)
* Fix the MJ integration breaking the Δv calculations and fairing autostaging. * Improve the handling of user input. * Note that the current staging icon handling is a major WIP ATM and does not work correctly.
* Not necessary but since i found the chance to do so...
* Just a typo, nothing to see here!
* Move some UI code outside of the FixedUpdate () methods. * Fix the fairing side staging icon states. * Trim some useless code.
This reverts commit 1e0585f.
Pulled in changes from PhineasFreak
… connected above it, which was breaking in KSP 1.4
Add config nodes for Rockomax parts in career mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Background:
Several months ago, the forums user KortexM had updated the binaries to fix some issues users were reporting. Technically, posting binaries without the source is against KSP rules, so I had reached out to KortexM to see where his code was for the changes he provided, but never heard back. He was last on the forums in February, and so I figured enough time had gone by that I should work on decompiling his binaries to create a diff. I tried myself, but was unsuccessful.
A few days ago, I had mentioned this in the realism overhaul forums, and Sarbian was able to generate a diff between the official 3.20 binary, and the "3.20b4" version KortexM had provided. This PR is my attempt to port those changes onto this codebase.
The diff was built from the binary KortexM posted here: http://forum.kerbalspaceprogram.com/index.php?/topic/36371-12-procedural-fairings-320-november-8/&do=findComment&comment=2937521
I've loaded this binary up in my RealismOverhaul install, and haven't seen any issues, but more testing would be appreciated.