Skip to content

Commit

Permalink
update test
Browse files Browse the repository at this point in the history
when I moved from the formatted alert to a plain alert, the text that ends up in the alert changed, but I did not update my test

also added a space between the title and the text
  • Loading branch information
Abby Wheelis committed Nov 6, 2023
1 parent 85d2884 commit 29f44e7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion www/__tests__/remoteNotifyHandler.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ it('handles the popup if subscribed', () => {
},
},
});
expect(getAlerts()).toEqual(expect.arrayContaining(['━━━━\nHello\n━━━━\nWorld']));
expect(getAlerts()).toEqual(expect.arrayContaining(['Hello World']));
});

it('does nothing if subscribed and no data', () => {
Expand Down
2 changes: 1 addition & 1 deletion www/js/splash/remoteNotifyHandler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ const onCloudNotifEvent = (event) => {
var popup_spec = data.additionalData.payload.spec;
if (popup_spec && popup_spec.title && popup_spec.text) {
/* TODO: replace popup with something with better UI */
window.alert(popup_spec.title + popup_spec.text);
window.alert(popup_spec.title + ' ' + popup_spec.text);
} else {
displayErrorMsg(JSON.stringify(popup_spec), 'popup was not specified correctly. spec is ');
}
Expand Down

0 comments on commit 29f44e7

Please sign in to comment.