Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove moped #1091

Merged
Merged

Conversation

sebastianbarry
Copy link
Contributor

Removed moped from en.json and the default label-options.json.sample files

In response to @shankari and @Abby-Wheelis in e-mission/e-mission-docs#1013 (comment)

@sebastianbarry
Copy link
Contributor Author

I also did a quick search of the codebase in service_rewrite_2023 for "moped" and found this location in diaryHelper.ts, do we want to keep this around?

image

@Abby-Wheelis
Copy link
Member

I think that's for the base mode moped, so we do want to keep that around for configs that do have that base mode. My understanding is that we support that underlying functionality (moped icon and color) for cases like usaid-laos-ev options, which does make use of that base mode. There's just no moped in the app by default, but we do support it. There's a few of those base modes that aren't in the default set - like "TROLLEYBUS" and "FERRY"

@shankari shankari merged commit 1dca6c8 into e-mission:service_rewrite_2023 Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants