-
Notifications
You must be signed in to change notification settings - Fork 119
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Corrected 1st log message for local emission environment
The tests failed since despite using ENV vars, it wasn’t picking up value. This was because ENV vars are being deleted in setUp(). Added CONDA_DEFAULT_ENV to the skipped env vars. However, this approach of fetching ENV vars programmatically in the assert statement isn’t correct. This is because the code in get_config() itself uses ENV vars to set the ret_val which is the exact value as being fetched in setUp(). Thus the values will always match. ——— Then I thought of adding another log message for the `emission` environment name. While testing this I found that the 1st message isn’t being used in the normal situations when testing locally. This message is observed when the conf/storage/db.conf file is used instead of the sample file. But in normal operation, the server repo doesn’t have any conf files to begin with. Additionally, we now set the DB_HOST as db and WEB_SERVER_HOST as 0.0.0.0 in the Dockerfile by default. Hence the assert log message should also contain `Config file not found…` message like the other two messages. It should also have DB_HOST set to Db like the 3rd message.
- Loading branch information
Mahadik, Mukul Chandrakant
authored and
Mahadik, Mukul Chandrakant
committed
Aug 22, 2024
1 parent
7ac46aa
commit 32681cf
Showing
1 changed file
with
8 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters