Refactor User Stats Tests to Pipeline-Dependent and Independent Updates

[TeachMeTW]

Description

Updates our tests for user statistics to reflect the recent refactor that separates pipeline-dependent statistics (such as trip counts and pipeline range) from pipeline-independent statistics (such as last_call_ts). Simplified the comments for brevity and to match the new changes.

Changes

Pipeline-Dependent Stats:

The test now verifies that after running the intake pipeline via etc.runIntakePipeline, the user profile is updated with:

• total_trips
• labeled_trips
• pipeline_range (with both start_ts and end_ts)

Pipeline-Independent Stats:

• The test verifies that when a server API call is stored, the last_call_ts field is updated correctly in the user profile.

Testing

python -m unittest emission/tests/analysisTests/intakeTests/TestUserStat.py

[JGreenlee]

Approved, given that it passes and the stats are now described accurately

Non-critical feedback below for learning. I know it is a hard habit to break, but there are still a lot of unnecessary inline comments.

There are some good reasons for inline comments:

• documenting decisions and trade-offs; why one approach was taken over another, especially if the other approach may be relevant later/elsewhere in the project
• flagging future changes or improvements to be made (TODO)
• offering a deeper explanation to what code does iff it is not already obvious at a surface level

However, comments that restate the code in words (e.g. i += 1 # increment i by 1) add noise without value

Remember, the ideal code needs little to no comments; it is already readable due to splitting code into understandable chunks and choosing meaningful variable and function names