Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance
_get_and_store_range
Function to Include Trip Statistics and Last API Call Tracking #993Enhance
_get_and_store_range
Function to Include Trip Statistics and Last API Call Tracking #993Changes from all commits
2541e0d
39a3358
ad33691
ae549f2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cleanup: is there a reason this should be hardcoded instead of being
trip_key
? In addition to being cleaner, this will also likely result in better performance, since repeated queries on the same objects are likely to hit the cache.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will be addressing in follow up pr; no reason it should be hard coded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record, and to assist in understanding #1003 (comment)
this should be the start of the first trip.
Why is not the first location if the location points were received before?
The background sensed objects don't have a
data.start_ts
, they are associated withdata.ts
So this must find a trip-like object; since they are the only ones who have a start_ts. So it would really be the start timestamp of the first procssed trip.
The
segmentation/raw_trip
is created with a start that corresponds to the start transition (as we do for draft trips). In theclean_and_resample
stage, we "fill in" the trip trajectory by interpolating to the end of the previous trip. So this should return thestart_ts
from a cleaned/confirmed/composite trip.@JGreenlee for visibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to make sense, but I am not sure how the the tests were working without this. It looks like I changed this ~ 3 years ago
a45d4e3
The change was almost certainly an unintentional typo but the tests have been passing consistently since then