-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add *Fake* Missing trips survey #10
Open
sebastianbarry
wants to merge
9
commits into
e-mission:main
Choose a base branch
from
sebastianbarry:missing-trips-survey
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add *Fake* Missing trips survey #10
sebastianbarry
wants to merge
9
commits into
e-mission:main
from
sebastianbarry:missing-trips-survey
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the survey-resources folder from e-mission-phone and all the associated survey json/xml/xls files
Added the surveys.json folder which contains the info about each survey that may be used on e-mission-phone (formPath, version number, compatibleWith, and dataKey) These surveys will be used by the configs, under survey_info.buttons.[button name here].survey-name ( which = "UserProfileSurvey" for example)
We are doing these changes for now only on the Devapp study/program, for testing - dev-emulator-program will contain the TimeUseSurvey buttons for trip-notes and place-notes - dev-emulator-study will NOT contain any button info because we will not be using the trip-notes or place-notes buttons. This will be the "control" version without the changes for the TimeUseSurvey
…or-study Added variants to the original dev-emulator-program/study. Adding onto the concept that program is the trip-notes and place-notes button for TimeUseSurvey and the study is the "control". These new variants introduce the "trip-labels" button which **if filled in** (with "TripConfirmSurvey") will display a trip confirm survey button instead of the typical Multilabel format of Mode: ??? Purpose: ???
So that we can join the newly added dev-emulator-program-tripconfirm and dev-emulator-study-tripconfirm, added them to index.html
Removed the trip-labels button and replaced it with a global one-line config named "trip-labels" which will be either ENKETO for TripConfirmSurvey or MUTLILABEL for the typical Mode: ??? Purpose: ??? - dev-emulator-program - dev-emulator-study - dev-emulator-program-tripconfirm - dev-emulator-study-tripconfirm index.html - Changed the devapp study names to indicate which is using Tripconfirm/Multilabel and TimeUseSurvey
For the sake of having to load in an entirely new config file (and to save time on this change) we will move the surveys field back into the dynamic config files PER study/program This makes loading the "formPath" much easier from the implementation on e-mission-phone
dev-emulator-program-missingtrip.nrel-op.json - Added the config file index.html - Added the link and QR code to the HTML page as well
@shankari and @JGreenlee adding for visibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created and implemented the Fake missing trips survey that takes the pre-existing
places-notes
code and adds the Missing Trip survey to that. The code as is mostly already handles it...Testing:
The only part that is not handled, is
answer.js
, meaning that the survey can never "Save"/complete because there is no code to handle this.My questions is: do we want to create a generic "Answer" to new surveys so that no matter what they can respond? Or will we need to create an answer in
LABEL_FUNCTIONS
(inanswer.js
) for each new survey we create, meaning that e-mission-phone will require an update for each new survey type we enter