Skip to content

Commit

Permalink
Merge pull request #81 from e-picsa/fix/android-permissions
Browse files Browse the repository at this point in the history
Fix/android permissions
  • Loading branch information
chrismclarke authored Nov 6, 2022
2 parents 44c675d + feb0b53 commit 31a872b
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 6 deletions.
4 changes: 2 additions & 2 deletions apps/picsa-apps/extension-app-native/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ android {
applicationId "io.picsa.extension"
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
versionCode 3013000
versionName "3.13.0"
versionCode 3013001
versionName "3.13.1"
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
aaptOptions {
// Files and dirs to omit from the packaged assets dir, modified to accommodate modern web apps.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
<manifest xmlns:android="http://schemas.android.com/apk/res/android" xmlns:tools="http://schemas.android.com/tools"
package="io.picsa.extension">

<!-- HACK -
remove permission from fileopener2 https://github.com/pwlin/cordova-plugin-file-opener2/issues/329
(also requires xmlns:tools="http://schemas.android.com/tools" in manifest tag above)
-->
<uses-permission android:name="android.permission.REQUEST_INSTALL_PACKAGES" tools:node="remove"/>
<application
android:allowBackup="true"
android:icon="@mipmap/ic_launcher"
Expand Down
3 changes: 1 addition & 2 deletions apps/picsa-apps/extension-app/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,7 @@
"with": "libs/environments/src/environment.prod.ts"
}
],
"outputHashing": "all",
"sourceMap": true
"outputHashing": "all"
},
"development": {
"buildOptimizer": false,
Expand Down
12 changes: 12 additions & 0 deletions documentation/developers/troubleshooting.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,15 @@ Known issue, related to how jest will attempt to recompile prior to running. Hav
- https://github.com/thymikee/jest-preset-angular/issues/1648

Will likely need to fork and rebuild repo to add better support (assuming esm module syntax)

### Play store rejected - sensitive permissions (REQUEST_INSTALL_PACKAGES )

Update `apps\picsa-apps\extension-app-native\android\app\src\main\AndroidManifest.xml` to remove permission

```
<uses-permission android:name="android.permission.REQUEST_INSTALL_PACKAGES" tools:node="remove"/>
```

This will also require adding `xmlns:tools="http://schemas.android.com/tools"` in manifest tag

See notes in https://github.com/pwlin/cordova-plugin-file-opener2/issues/329
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "picsa-apps",
"version": "3.13.0",
"version": "3.13.1",
"license": "See LICENSE",
"scripts": {
"ng": "nx",
Expand Down

0 comments on commit 31a872b

Please sign in to comment.