fix: remove android permission

e-picsa · Nov 6, 2022 · cb0ed52 · cb0ed52
1 parent 44c675d
commit cb0ed52
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 4 deletions.
diff --git a/apps/picsa-apps/extension-app-native/android/app/build.gradle b/apps/picsa-apps/extension-app-native/android/app/build.gradle
@@ -6,8 +6,8 @@ android {
         applicationId "io.picsa.extension"
         minSdkVersion rootProject.ext.minSdkVersion
         targetSdkVersion rootProject.ext.targetSdkVersion
-        versionCode 3013000
-        versionName "3.13.0"
+        versionCode 3013001
+        versionName "3.13.1"
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
         aaptOptions {
              // Files and dirs to omit from the packaged assets dir, modified to accommodate modern web apps.

diff --git a/apps/picsa-apps/extension-app-native/android/app/src/main/AndroidManifest.xml b/apps/picsa-apps/extension-app-native/android/app/src/main/AndroidManifest.xml
@@ -1,7 +1,12 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+<manifest xmlns:android="http://schemas.android.com/apk/res/android" xmlns:tools="http://schemas.android.com/tools"
     package="io.picsa.extension">
 
+    <!-- HACK - 
+    remove permission from fileopener2 https://github.com/pwlin/cordova-plugin-file-opener2/issues/329 
+    (also requires xmlns:tools="http://schemas.android.com/tools" in manifest tag above)
+    -->
+    <uses-permission android:name="android.permission.REQUEST_INSTALL_PACKAGES" tools:node="remove"/>
     <application
         android:allowBackup="true"
         android:icon="@mipmap/ic_launcher"

diff --git a/documentation/developers/troubleshooting.md b/documentation/developers/troubleshooting.md
@@ -25,3 +25,15 @@ Known issue, related to how jest will attempt to recompile prior to running. Hav
 - https://github.com/thymikee/jest-preset-angular/issues/1648
 
 Will likely need to fork and rebuild repo to add better support (assuming esm module syntax)
+
+### Play store rejected - sensitive permissions (REQUEST_INSTALL_PACKAGES )
+
+Update `apps\picsa-apps\extension-app-native\android\app\src\main\AndroidManifest.xml` to remove permission
+
+```
+<uses-permission android:name="android.permission.REQUEST_INSTALL_PACKAGES" tools:node="remove"/>
+```
+
+This will also require adding `xmlns:tools="http://schemas.android.com/tools"` in manifest tag
+
+See notes in https://github.com/pwlin/cordova-plugin-file-opener2/issues/329
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "picsa-apps",
-  "version": "3.13.0",
+  "version": "3.13.1",
   "license": "See LICENSE",
   "scripts": {
     "ng": "nx",