-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sorting for participants in Issue #1975 #2061
Sorting for participants in Issue #1975 #2061
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if sorting by the percentage is really what we want here. @janno42 ?
Yes, ordering by percentage of voters is specified in the issue and what we want here. |
Hey @constantin-kuehne and @till2 do you want to continue working on this or should we take over? |
@janno42 is this order fine: Courses with multiple evaluations first, then single results, then evaluations with ascending voter percentage (or the other way around if sorted descending)? Especially asking for courses with multiple evaluations, I could see that we'd want to average out the voter percentages of all their evaluations. |
Offline discussion results:
-> proposal:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely, some last questions
This implements sorting on the participants on the evaluation result page. It is only part of the issue #1975.
Co-authored-by: @till2