Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting for participants in Issue #1975 #2061

Merged
merged 10 commits into from
Feb 5, 2024

Conversation

constantin-kuehne
Copy link
Collaborator

This implements sorting on the participants on the evaluation result page. It is only part of the issue #1975.
Co-authored-by: @till2

@janno42 janno42 self-requested a review November 5, 2023 18:04
Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if sorting by the percentage is really what we want here. @janno42 ?

evap/evaluation/models.py Outdated Show resolved Hide resolved
evap/results/templates/results_index_evaluation_impl.html Outdated Show resolved Hide resolved
@janno42
Copy link
Member

janno42 commented Nov 20, 2023

Yes, ordering by percentage of voters is specified in the issue and what we want here.
Finding courses of a certain size will be implemented via the participant count filter.

@richardebeling
Copy link
Member

Hey @constantin-kuehne and @till2 do you want to continue working on this or should we take over?

@richardebeling
Copy link
Member

@janno42 is this order fine: Courses with multiple evaluations first, then single results, then evaluations with ascending voter percentage (or the other way around if sorted descending)? Especially asking for courses with multiple evaluations, I could see that we'd want to average out the voter percentages of all their evaluations.

image

@richardebeling
Copy link
Member

Offline discussion results:

  • We don't really care if single results are above or below the other results. They should however we grouped together.
  • For courses with multiple evaluations, it probably makes sense to take the maximum voter participation ratio as a sorting criterion. An evaluation voter ratio gives more information here than a single result voter count, so it should be preferred for sorting

-> proposal:

  • Voter ratios are in [0, 1]
  • single results get a score of 0 (as they currently do)
  • A course's data-order score is the max of the scores of its evaluations

@richardebeling richardebeling self-assigned this Jan 22, 2024
@niklasmohrin niklasmohrin removed their request for review January 29, 2024 20:28
Copy link
Member

@janno42 janno42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great stuff

Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely, some last questions

evap/evaluation/models.py Show resolved Hide resolved
evap/static/ts/src/datagrid.ts Outdated Show resolved Hide resolved
@richardebeling richardebeling merged commit 0c1796e into e-valuation:main Feb 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants