Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker SDK Usage #432

Closed
wants to merge 11 commits into from
Closed

Docker SDK Usage #432

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c0e186d
init: add basic tests to iterate on docker changes
danstarns Aug 24, 2024
b50ca86
test: add API key assert
danstarns Aug 24, 2024
13443c7
test: add no docker file assert
danstarns Aug 24, 2024
f096c73
refactor: remove snapshots
danstarns Aug 24, 2024
c84c61d
feat: add mocks for docker build
danstarns Aug 25, 2024
39fcf85
git: ignore e2b.toml
danstarns Aug 25, 2024
6893c52
feat: add dockerode and use that in connect
danstarns Aug 25, 2024
e44f5d2
ci: run the cli unit tests
danstarns Aug 25, 2024
95cb302
lock updates
danstarns Aug 25, 2024
b0267f5
refactor: usage of dockerode sdk
danstarns Aug 25, 2024
78f491a
lint changes
danstarns Aug 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/cli_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,8 @@ jobs:

- name: Test build
run: pnpm build

- name: Run node tests
run: pnpm run test:unit
env:
E2B_API_KEY: ${{ secrets.E2B_API_KEY }}
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,3 +287,4 @@ cython_debug/
# and can be added to the global gitignore or merged into this file. For a more nuclear
# option (not recommended) you can uncomment the following to ignore the entire idea folder.
.idea/
e2b.toml
8 changes: 7 additions & 1 deletion packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,22 @@
"build": "tsc --noEmit --skipLibCheck && tsup --minify",
"dev": "tsup --watch",
"test": "pnpm build && cd testground/demo-basic && ../../dist/index.js template build",
"test:unit": "vitest run",
"check-deps": "knip",
"update-deps": "ncu -u && pnpm i"
},
"devDependencies": {
"@types/command-exists": "^1.2.3",
"@types/dockerode": "^3.3.31",
"@types/inquirer": "^9.0.7",
"@types/node": "^18.18.6",
"@types/update-notifier": "6.0.5",
"dotenv": "^16.4.5",
"knip": "^2.33.4",
"npm-check-updates": "^16.14.6",
"tsup": "^7.2.0",
"typescript": "^5.2.2"
"typescript": "^5.2.2",
"vitest": "^0.34.6"
},
"files": [
"dist",
Expand All @@ -55,9 +59,11 @@
"command-exists": "^1.2.9",
"commander": "^11.1.0",
"console-table-printer": "^2.11.2",
"dockerode": "^4.0.2",
"e2b": "^0.16.2",
"inquirer": "^9.2.12",
"open": "^9.1.0",
"ssh2": "^1.15.0",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added as a peer of dockerode, resolves issue in testing:

Can't resolve './crypto/build/Release/sshcrypto.node'

Related:

"strip-ansi": "^7.1.0",
"update-notifier": "5.1.0",
"yup": "^1.3.2"
Expand Down
Loading