Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auxiliar InternalWriter #138

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

juanlofer-eprosima
Copy link
Contributor

Move already existing helper class from Fast-DDS-spy repo so that it can be reused in other tools.

Signed-off-by: Juan Lopez Fernandez <[email protected]>
Copy link

@EugenioCollado EugenioCollado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 37.83%. Comparing base (f6fec3c) to head (fc5e554).

Files with missing lines Patch % Lines
...cipants/src/cpp/writer/auxiliar/InternalWriter.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   37.86%   37.83%   -0.03%     
==========================================
  Files         152      153       +1     
  Lines        6956     6961       +5     
  Branches     2764     2765       +1     
==========================================
  Hits         2634     2634              
- Misses       2937     2942       +5     
  Partials     1385     1385              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanlofer-eprosima juanlofer-eprosima merged commit efc83a4 into main Dec 19, 2024
17 checks passed
@juanlofer-eprosima juanlofer-eprosima deleted the feature/internal-writer branch December 19, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants