Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19983] Publish Fast-DDS's Logs #436

Merged
merged 8 commits into from
Mar 7, 2024
Merged

[19983] Publish Fast-DDS's Logs #436

merged 8 commits into from
Mar 7, 2024

Conversation

@Tempate Tempate force-pushed the feature/publish_logs branch from 36e6a56 to 2cbc600 Compare March 1, 2024 11:01
@Tempate Tempate changed the base branch from main to feature/fault_reporting March 1, 2024 11:47
@LuciaEchevarria99 LuciaEchevarria99 force-pushed the feature/fault_reporting branch from 4286c1b to 1d7c028 Compare March 5, 2024 14:29
Base automatically changed from feature/fault_reporting to main March 6, 2024 09:02
Copy link
Contributor

@LuciaEchevarria99 LuciaEchevarria99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 30.74%. Comparing base (9128706) to head (76baa58).
Report is 1 commits behind head on main.

Files Patch % Lines
tools/ddsrouter_tool/src/cpp/main.cpp 0.00% 2 Missing and 7 partials ⚠️
...dsrouter_yaml/src/cpp/YamlReader_configuration.cpp 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
- Coverage   31.45%   30.74%   -0.71%     
==========================================
  Files          15       16       +1     
  Lines         531      553      +22     
  Branches      274      291      +17     
==========================================
+ Hits          167      170       +3     
- Misses        191      200       +9     
- Partials      173      183      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rsanchez15 rsanchez15 merged commit 29de75f into main Mar 7, 2024
28 of 31 checks passed
@rsanchez15 rsanchez15 deleted the feature/publish_logs branch March 7, 2024 07:00
Tempate added a commit that referenced this pull request Mar 8, 2024
* Register a DdsLogConsumer to publish the logs

Signed-off-by: tempate <[email protected]>

* Apply suggestions

Signed-off-by: tempate <[email protected]>

* Minor changes

Signed-off-by: tempate <[email protected]>

* Apply self-suggestions

Signed-off-by: tempate <[email protected]>

* Documentation

Signed-off-by: tempate <[email protected]>

* Apply suggestions

Signed-off-by: tempate <[email protected]>

* Delete the log consumers before closing

Signed-off-by: tempate <[email protected]>

* Uncrustify

Signed-off-by: tempate <[email protected]>

---------

Signed-off-by: tempate <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants