-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[19983] Publish Fast-DDS's Logs #436
Conversation
ddsrouter_core/include/ddsrouter_core/configuration/SpecsConfiguration.hpp
Show resolved
Hide resolved
36e6a56
to
2cbc600
Compare
ddsrouter_core/include/ddsrouter_core/configuration/SpecsConfiguration.hpp
Show resolved
Hide resolved
4286c1b
to
1d7c028
Compare
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
4f29ae8
to
76baa58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #436 +/- ##
==========================================
- Coverage 31.45% 30.74% -0.71%
==========================================
Files 15 16 +1
Lines 531 553 +22
Branches 274 291 +17
==========================================
+ Hits 167 170 +3
- Misses 191 200 +9
- Partials 173 183 +10 ☔ View full report in Codecov by Sentry. |
* Register a DdsLogConsumer to publish the logs Signed-off-by: tempate <[email protected]> * Apply suggestions Signed-off-by: tempate <[email protected]> * Minor changes Signed-off-by: tempate <[email protected]> * Apply self-suggestions Signed-off-by: tempate <[email protected]> * Documentation Signed-off-by: tempate <[email protected]> * Apply suggestions Signed-off-by: tempate <[email protected]> * Delete the log consumers before closing Signed-off-by: tempate <[email protected]> * Uncrustify Signed-off-by: tempate <[email protected]> --------- Signed-off-by: tempate <[email protected]>
In this version, users can configure through the YAML the publication of Fast DDS's logs.
Merge after: