Skip to content

Commit

Permalink
Fixed whitelist and bug with xml structure literal include (#34)
Browse files Browse the repository at this point in the history
* Refs #5388 Fixed whitelist and bug with xml structure literal include.

* Refs #5389 Requested changes

* Update code/XMLTester.xml

Co-Authored-By: MiguelCompany <[email protected]>

* Refs #5389 Requested changes
  • Loading branch information
Luis Gasco authored and MiguelCompany committed May 14, 2019
1 parent b1502c3 commit f91e754
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 23 deletions.
44 changes: 22 additions & 22 deletions code/XMLTester.xml
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
<qos>
<lifespan>
<duration>
<sec>1</sec>
<sec>1</sec>
</duration>
</lifespan>
</qos>
Expand All @@ -127,7 +127,7 @@
<qos>
<lifespan>
<duration>
<sec>1</sec>
<sec>1</sec>
</duration>
</lifespan>
</qos>
Expand All @@ -138,9 +138,9 @@
<publisher profile_name="publisher_xml_conf_disable_positive_acks_profile">
<qos>
<disablePositiveAcks>
<enabled>true</enabled>
<enabled>true</enabled>
<duration>
<sec>1</sec>
<sec>1</sec>
</duration>
</disablePositiveAcks>
</qos>
Expand All @@ -149,7 +149,7 @@
<subscriber profile_name="subscriber_xml_conf_disable_positive_acks_profile">
<qos>
<disablePositiveAcks>
<enabled>true</enabled>
<enabled>true</enabled>
</disablePositiveAcks>
</qos>
</subscriber>
Expand All @@ -160,8 +160,8 @@
<qos>
<deadline>
<period>
<sec>1</sec>
</period>
<sec>1</sec>
</period>
</deadline>
</qos>
</publisher>
Expand All @@ -170,8 +170,8 @@
<qos>
<deadline>
<period>
<sec>1</sec>
</period>
<sec>1</sec>
</period>
</deadline>
</qos>
</subscriber>
Expand Down Expand Up @@ -579,8 +579,8 @@
<maxMessageSize>16384</maxMessageSize> <!-- uint32 -->
<maxInitialPeersRange>100</maxInitialPeersRange> <!-- uint32 -->
<interfaceWhiteList>
<id>192.168.1.41</id> <!-- string -->
<id>127.0.0.1</id> <!-- string -->
<address>192.168.1.41</address> <!-- string -->
<address>127.0.0.1</address> <!-- string -->
</interfaceWhiteList>
<wan_addr>80.80.55.44</wan_addr> <!-- string -->
<output_port>5101</output_port> <!-- uint16 -->
Expand Down Expand Up @@ -712,7 +712,7 @@
<case>
<caseDiscriminator value="0"/>
<caseDiscriminator value="1"/>
<member name="first" type="int32"/>
<member name="first" type="int32"/>
</case>
<case>
<caseDiscriminator value="2"/>
Expand Down Expand Up @@ -856,8 +856,8 @@
</rtps>
</participant>
<!--><-->
<!-- Not Used at the moment -->
<!-- <userData>148875 </userData> -->
<!-- Not Used at the moment -->
<!-- <userData>148875 </userData> -->

<participant profile_name="part_builtin_example">
<rtps>
Expand Down Expand Up @@ -1217,8 +1217,8 @@
<maxMessageSize>16384</maxMessageSize>
<maxInitialPeersRange>100</maxInitialPeersRange>
<interfaceWhiteList>
<id>192.168.1.41</id>
<id>127.0.0.1</id>
<address>192.168.1.41</address>
<address>127.0.0.1</address>
</interfaceWhiteList>
<wan_addr>80.80.55.44</wan_addr>
<keep_alive_frequency_ms>5000</keep_alive_frequency_ms>
Expand Down Expand Up @@ -1569,12 +1569,12 @@
<publishMode>
<kind>ASYNCHRONOUS</kind>
</publishMode>
<disablePositiveAcks>
<enabled>true</enabled>
<duration>
<sec>1</sec>
</duration>
</disablePositiveAcks>
<disablePositiveAcks>
<enabled>true</enabled>
<duration>
<sec>1</sec>
</duration>
</disablePositiveAcks>
</qos>

<times>
Expand Down
2 changes: 1 addition & 1 deletion docs/xmlprofiles.rst
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ An XML file can contain several XML profiles. The available profile types are :r
.. literalinclude:: ../code/XMLTester.xml
:language: xml
:start-after: <!-->PROFILES-TRANSPORT-DESCRIPTORS<-->
:lines: 1-6, 11-32
:lines: 1-6, 43-63

The Fast-RTPS XML format uses some structures along several profiles types.
For readability, the :ref:`commonxml` section groups these common structures.
Expand Down

0 comments on commit f91e754

Please sign in to comment.