Process an empty YAML when a configuration file isn't provided #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
- Coverage 65.19% 64.96% -0.23%
==========================================
Files 22 22
Lines 1109 1119 +10
Branches 389 395 +6
==========================================
+ Hits 723 727 +4
- Misses 137 141 +4
- Partials 249 251 +2 ☔ View full report in Codecov by Sentry. |
irenebm
suggested changes
Dec 18, 2023
Tempate
force-pushed
the
bugfix/process_yaml_without_file
branch
from
c3b6753 to
db43dd2
Compare
Tempate
force-pushed
the
bugfix/process_yaml_without_file
branch
from
1fc0a89 to
c8346de
Compare
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Tempate
force-pushed
the
bugfix/process_yaml_without_file
branch
from
c8346de to
cce52b9
Compare
irenebm
suggested changes
Jan 8, 2024
| @@ -0,0 +1,45 @@ | |||
| # Copyright 2023 Proyectos y Sistemas de Mantenimiento SL (eProsima). | |||
There was a problem hiding this comment.
Suggested change
| # Copyright 2023 Proyectos y Sistemas de Mantenimiento SL (eProsima). | |
| # Copyright 2024 Proyectos y Sistemas de Mantenimiento SL (eProsima). |
There was a problem hiding this comment.
It's what happens when you take a year to review my PRs...
There was a problem hiding this comment.
Cheers to the power of patience and precision! Like a fine wine, my PRs took time to mature, and the celebration is just as sweet. Here's to the art of meticulous review and the joy of progress!
fastddsspy_tool/test/application/test_cases/tool_topics_dds_no_config.py
Outdated
Show resolved
Hide resolved
Signed-off-by: tempate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version, when a user didn't provide a configuration file, the Fast-DDS Spy didn't process the default YAML configuration. To fix it, in this version when a configuration file isn't provided, the Fast-DDS Spy processes an empty YAML into which it loads the default YAML configuration.