Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21227] Utility to convert QoS ids and masks to string (backport #120) #121

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jul 2, 2024

This version includes qos_policy_id_to_string to convert a QosPolicyId_t to string and qos_policy_mask_to_string to convert a PolicyMask to string.


This is an automatic backport of pull request #120 done by Mergify.

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 54.44444% with 41 lines in your changes missing coverage. Please review.

Please upload report for BASE (0.x@8726f05). Learn more about missing BASE report.

Files Patch % Lines
cpp_utils/src/cpp/qos/qos_utils.cpp 54.44% 0 Missing and 41 partials ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             0.x     #121   +/-   ##
======================================
  Coverage       ?   66.09%           
======================================
  Files          ?       63           
  Lines          ?     1637           
  Branches       ?      469           
======================================
  Hits           ?     1082           
  Misses         ?      268           
  Partials       ?      287           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Tempate and others added 2 commits July 3, 2024 10:59
* Auxiliar methods to convert to string QoS ids and policies

Signed-off-by: tempate <[email protected]>

* Documentation

Signed-off-by: tempate <[email protected]>

* Uncrustify

Signed-off-by: tempate <[email protected]>

* Tests

Signed-off-by: tempate <[email protected]>

* Print invalid policy masks as invalid

Signed-off-by: tempate <[email protected]>

* Apply self-suggestions

Signed-off-by: tempate <[email protected]>

* Apply suggestions

Signed-off-by: tempate <[email protected]>

---------

Signed-off-by: tempate <[email protected]>
(cherry picked from commit ee4e7d0)
Signed-off-by: tempate <[email protected]>
Copy link
Contributor

@LuciaEchevarria99 LuciaEchevarria99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tempate Tempate merged commit 2a206e4 into 0.x Jul 3, 2024
17 checks passed
@Tempate Tempate deleted the mergify/bp/0.x/pr-120 branch July 3, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants