-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfixes and larger AppIcon #51
Conversation
And one suggestion: |
Great work, thanks for the PR! |
I also did a complete refactoring of the code to have a more modular structure. https://github.com/relikd/ProvisionQL/tree/refactor_rewrite In the next few days I plan to:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
I've noticed indentation inconsistency and converted all tabs to spaces before merging.
Hi there and thank you for this QL plugin.
My commits follow semantic naming so it is probably easier to read by commits than by overall changes ;-)
This PR:
--xml
flag. f5facd5CFBundleShortVersionString
for an iOS 3.2 ipa)PS: I removed the
@"-x", @"*/*/*/*"
args as I think it is not used for single file unzips anyway? Let me know if this was a mistake. Otherwise the console will always printing the following error: