Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes and larger AppIcon #51

Merged
merged 11 commits into from
Feb 11, 2024
Merged

Conversation

relikd
Copy link
Contributor

@relikd relikd commented Jan 21, 2024

Hi there and thank you for this QL plugin.
My commits follow semantic naming so it is probably easier to read by commits than by overall changes ;-)

This PR:

  • fix codesign on 10.15 has no --xml flag. f5facd5
  • fix crash if Plist key is not present. 2a339fc (in my case CFBundleShortVersionString for an iOS 3.2 ipa)
  • use higher resolution app icon (iTunesArtwork) if available. 5ddcdc9
  • slightly larger icon in preview (and fixed-width icons for consistent placement).
  • some refactoring to reduce duplicate code

PS: I removed the @"-x", @"*/*/*/*" args as I think it is not used for single file unzips anyway? Let me know if this was a mistake. Otherwise the console will always printing the following error:

caution: excluded filename not matched:  */*/*/*

@relikd
Copy link
Contributor Author

relikd commented Jan 21, 2024

  • fix IconFlavor

And one suggestion:
I think we should remove the .provision drawing in the thumbnail generator. Isnt the thumbnail icon cached anyway? How useful is an expiration status if it is not updated?

@ealeksandrov ealeksandrov self-requested a review January 22, 2024 20:50
@ealeksandrov
Copy link
Owner

Great work, thanks for the PR!
I'll take closer look and test it later this week.

@relikd
Copy link
Contributor Author

relikd commented Jan 25, 2024

I also did a complete refactoring of the code to have a more modular structure. https://github.com/relikd/ProvisionQL/tree/refactor_rewrite
Not sure if you first want to review the changes in this PR or jump into the refactor straight ahead (I can create the necessary PR if you like).

In the next few days I plan to:

  • implement Want to show Apple ID info #26
  • try to use zlib to unzip ipa content instead of launching a sys command
  • maybe get support for Asset.car files if I get the private API to work. (or fallback to convert with iconutil)

@ealeksandrov ealeksandrov merged commit 9ff3104 into ealeksandrov:master Feb 11, 2024
1 check passed
Copy link
Owner

@ealeksandrov ealeksandrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! :shipit:
I've noticed indentation inconsistency and converted all tabs to spaces before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants