auth checking in mutations #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…auth checking on mutation created file ---exceptions.py ---permissions.py updated file ---mutations.py
…auth checking on mutation created file ---exceptions.py ---permissions.py updated file ---mutations.py
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
==========================================
- Coverage 53.65% 53.34% -0.32%
==========================================
Files 24 26 +2
Lines 1968 2034 +66
==========================================
+ Hits 1056 1085 +29
- Misses 912 949 +37
Continue to review full report at Codecov.
|
|
I am new to all this so can you explain what these tests failing mean? And i was looking we can also make DjangoSerializerMutation class to have auth functionality instead of other class with auth name so what do you recommend ? |
|
oh sorry i found that there are no tests available to test new code that i wrote so should i provide tests for new functionality as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Feature to be included Auth for mutation and Queries
I was working on my personal project and had to use auth checking for mutations so i wrote a child class from existing DjangoSerializerMutation that does all permission checking and auth checking for create update and delete methods and was hoping that these changes could easily be included in current graphene-django-extras so let me know what you guys think and i am willing to include auth for other classes as well as i will write for my personal project any way
currently there is a sub class for auth but we can easily make DjangoSerializerMutation to have auth functionality
so let me know i am will to add this feature