-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make MesonNinja
respect the toolchainopts with buildtype as well as --debug
and --optimization
flags
#3454
Merged
Merged
Make MesonNinja
respect the toolchainopts with buildtype as well as --debug
and --optimization
flags
#3454
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f54380c
Make mesonninja easyblock respect toolchainopts
Micket a75f53d
Update easybuild/easyblocks/generic/mesonninja.py
Micket 23d8254
Fix use of property correctly, removing extra paranthesis
Micket 17909f2
Fix --debug flag.
Micket 100cbb6
Add NDEBUG flag to meson builds
Micket ec8642e
Make mesons optimization/debug flags mutually exclusive with buildtype
Micket 9742934
Add opt variant to optimization levels
Micket File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait, what if we have
'opt': True
(as in, use-O3
)?surely this needs another elif?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.