-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use *DESCRIPTION
rather than */DESCRIPTION
in RPackage.requires_deps
#3490
use *DESCRIPTION
rather than */DESCRIPTION
in RPackage.requires_deps
#3490
Conversation
*DESCRIPTION
rather than */DESCRIPTION
in RPackage.requires_deps
@boegelbot please test @ jsc-zen3 |
@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2416679677 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (1 easyconfigs in total) |
(created using
eb --new-pr
)The
DESCRIPTION
file is not always in a subdirectory in the tarball,RcisTarget_1.22.0.tar
is a example of that.We can get rid of that assumption by simply using
*DESCRIPTION
, which works fine regardless of whether theDESCRIPTION
file is in a subdirectory or not: