Skip to content

Commit

Permalink
Merge pull request #637 from easystats/release_0_18_3
Browse files Browse the repository at this point in the history
prepare CRAN release
  • Loading branch information
strengejacke authored Sep 18, 2022
2 parents 46b89fe + 08933d9 commit 2264791
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 7 deletions.
6 changes: 3 additions & 3 deletions CRAN-SUBMISSION
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Version: 0.18.2
Date: 2022-08-10 06:14:58 UTC
SHA: a09371bf70ac7b416e6d718db7e5dcea9e3211f8
Version: 0.18.3
Date: 2022-09-18 18:53:53 UTC
SHA: f7d20be0cb4847676f9c82720449189852f9380b
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Type: Package
Package: insight
Title: Easy Access to Model Information for Various Model Objects
Version: 0.18.2.9
Version: 0.18.3
Authors@R:
c(person(given = "Daniel",
family = "Lüdecke",
Expand Down Expand Up @@ -158,7 +158,7 @@ VignetteBuilder:
knitr
Encoding: UTF-8
Language: en-US
RoxygenNote: 7.2.1.9000
RoxygenNote: 7.2.1
Roxygen: list(markdown = TRUE)
Config/testthat/edition: 3
Config/Needs/website:
Expand Down
2 changes: 1 addition & 1 deletion R/get_statistic.R
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,7 @@ get_statistic.coxph <- function(x, ...) {
# avoid calling default method which would be computationally wasteful, since
# we need summary() here.
cs <- suppressWarnings(stats::coef(summary(x)))
column_index <- grep("^z$|^t$", colnames(cs))
column_index <- grep("^z$|^t$|Chisq", colnames(cs))
out <- data.frame(
Parameter = row.names(cs),
Statistic = cs[, column_index, drop = TRUE],
Expand Down
1 change: 0 additions & 1 deletion cran-comments.md
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
This release fixes CRAN check errors. Please cancel the submussion of insight 0.18.1, as this submission fixes issues with packages that have non-standard licenses.
9 changes: 9 additions & 0 deletions tests/testthat/test-coxph.R
Original file line number Diff line number Diff line change
Expand Up @@ -148,4 +148,13 @@ test_that("get_statistic", {
z1 <- get_statistic(mod)$Statistic
z2 <- coef(summary(mod))[, "z"]
expect_equal(z1, z2, ignore_attr = TRUE)

lung <- survival::lung
mod <- survival::coxph(
formula = Surv(time, status) ~ age + sex + frailty(inst),
data = lung
)
z1 <- get_statistic(mod)$Statistic
z2 <- coef(summary(mod))[, "Chisq"]
expect_equal(z1, z2, ignore_attr = TRUE)
})

1 comment on commit 2264791

@IndrajeetPatil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start also including change log in releases. I've done it for 0.18.3:

https://github.com/easystats/insight/releases/tag/0.18.3

Please sign in to comment.