-
-
Notifications
You must be signed in to change notification settings - Fork 39
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Prepare CRAN submission * cran comments * comments * fix * fix vctrs issue * news * typo * submitted
- Loading branch information
1 parent
24c23c4
commit 94b3377
Showing
8 changed files
with
55 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
Version: 0.19.11 | ||
Date: 2024-05-12 17:57:07 UTC | ||
SHA: b850f730c05480293504a2b81217d9244de20f3e | ||
Version: 0.20.0 | ||
Date: 2024-06-03 12:54:55 UTC | ||
SHA: 40c4fbce021ca275d823719e60f74717ff61f33d |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,9 @@ | ||
This release is required for the planned update of the 'parameters' package, which will be released once 'insight' is on CRAN. The 'parameters' update fixes errors in CRAN checks. | ||
This release fixes errors in CRAN checks. | ||
|
||
Additionally, in the process of stabilizing the API/user interface for packages | ||
from the 'easystats' project, some argument names were renamed and old names | ||
have been deprecated. This will *not break* downstream dependent packages, however, | ||
reverse-dependency checks will raise warnings. We have already patched all | ||
affected downstream packages and will submit them to CRAN in the next few days, | ||
after the release of 'insight'. Once this release-cycle is complete, all | ||
warnings due to deprecated argument names should be resolved. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,27 @@ | ||
test_that("compact_list works as expected", { | ||
expect_equal(compact_list(list(NULL, 1, c(NA, NA))), list(1, c(NA, NA))) | ||
expect_equal(compact_list(c(1, NA, NA)), c(1, NA, NA)) | ||
expect_equal(compact_list(list(NULL, 1, list(NULL, NULL))), list(1)) | ||
expect_equal(compact_list(c(1, NA, NA), remove_na = TRUE), 1) | ||
expect_equal(compact_list(c(1, 2, 3), remove_na = TRUE), c(1, 2, 3)) | ||
expect_equal(compact_list(""), "") | ||
expect_identical(compact_list(list(NULL, 1, c(NA, NA))), list(1, c(NA, NA))) | ||
expect_identical(compact_list(c(1, NA, NA)), c(1, NA, NA)) | ||
expect_identical(compact_list(list(NULL, 1, list(NULL, NULL))), list(1)) | ||
expect_identical(compact_list(c(1, NA, NA), remove_na = TRUE), 1) | ||
expect_identical(compact_list(c(1, 2, 3), remove_na = TRUE), c(1, 2, 3)) | ||
expect_identical(compact_list(""), "") | ||
expect_null(compact_list(NULL)) | ||
expect_equal(compact_list(logical(0)), logical(0)) | ||
expect_identical(compact_list(logical(0)), logical(0)) | ||
}) | ||
|
||
test_that("compact_list, logical > 1", { | ||
x <- list(a = 1, b = c(1, 2), c = NA) | ||
expect_equal(compact_list(x, remove_na = TRUE), list(a = 1, b = c(1, 2))) | ||
expect_equal(compact_list(x, remove_na = FALSE), list(a = 1, b = c(1, 2), c = NA)) | ||
expect_identical(compact_list(x, remove_na = TRUE), list(a = 1, b = c(1, 2))) | ||
expect_identical(compact_list(x, remove_na = FALSE), list(a = 1, b = c(1, 2), c = NA)) | ||
x <- list(a = 1, b = c(NA, NA), c = NA) | ||
expect_equal(compact_list(x, remove_na = TRUE), list(a = 1)) | ||
expect_equal(compact_list(x, remove_na = FALSE), list(a = 1, b = c(NA, NA), c = NA)) | ||
expect_identical(compact_list(x, remove_na = TRUE), list(a = 1)) | ||
expect_identical(compact_list(x, remove_na = FALSE), list(a = 1, b = c(NA, NA), c = NA)) | ||
}) | ||
|
||
test_that("compact_list, vctrs", { | ||
data(mtcars) | ||
class(mtcars$mpg) <- c("haven_labelled", "vctrs_vctr", "double") | ||
attr(mtcars$mpg, "labels") <- c(`21` = 21) | ||
out <- compact_list(mtcars) | ||
expect_true(all(vapply(out, class, character(1)) == "numeric")) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
# Currently doesn't work on devel - potential fixest issue? | ||
skip_if(TRUE) | ||
|
||
skip_on_os("mac") | ||
|