Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicated function multiFuseObjs_wColors #258

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tolot27
Copy link
Contributor

@tolot27 tolot27 commented Jan 2, 2019

It looks like multiFuseObjs_wColors is duplicated at

def multiFuseObjs_wColors(App, Gui, docName, objs, keepOriginals=False):

@Qbort
Copy link
Contributor

Qbort commented Jun 17, 2020

Is there any reason why this PR was not merged? It seems quite a good idea to fix a duplicate function in the file.

@Franck78
Copy link
Contributor

Franck78 commented Sep 5, 2020

The endind of the two function is different.

I think only René @poeschlr can tell what is the intention here and remove duplicate things.

      # Remove the fusion itself
-    fusedObj = App.ActiveDocument.ActiveObject
-    SimpleCopy_wColors(fusedObj)
-    FreeCAD.ActiveDocument.removeObject(fusedObj.Name)
-    fused_obj = App.ActiveDocument.ActiveObject
+    App.getDocument(docName).removeObject("Fusion")
 
     return fused_obj

@Franck78
Copy link
Contributor

Franck78 commented Oct 7, 2020

ping @poeschlr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants