Fix crash issue on Linux for games using platform: other #1630
+17
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: I'm not a TypeScript main, but I think I've found a fix for the crash issue in the following reports: #1577, #1458.
Basically what's going on is that the moveToNextScreen() function assumes that if a game is on Linux, then the GameDirectoryResolver for it will have Linux-specific functions available (isProtonGame and getLaunchArgs), but this isn't the case for DRMFreeDirectoryResolver, which is what is used if the platform is set to OTHER. I've worked around this by simply bypassing whatever's happening in Splash.vue. This seems to let r2modman boot up okay, although I have no idea what this code is supposed to be doing, so I've set this to draft for now so someone can take a look at it.