Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose.yml: switch to normal digest to pin browsers for cypress #6188

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

BacLuc
Copy link
Contributor

@BacLuc BacLuc commented Oct 20, 2024

Because updating them with renovate did not work.
There is anyway only one build with a digest for the
browser versions per build...and they would not be updated under the hood because
that would change the digest

See bacluc-test-org@5577beb
and bacluc-test-org@edceebf
on https://github.com/bacluc-test-org/ecamp3/commits/renovate/cypress/

@BacLuc BacLuc requested a review from a team October 20, 2024 19:55
@BacLuc BacLuc mentioned this pull request Oct 27, 2024
@BacLuc
Copy link
Contributor Author

BacLuc commented Nov 5, 2024

Review hier wäre cool, dann können wir cypress wieder automatisiert updaten...
@manuelmeister, @usu

Copy link
Member

@pmattmann pmattmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich sehe, dass es funktioniert. Ich verstehe jedoch nicht wieso.

Das Regex-Pattern enthält ', welche im docker-compose.yml nicht enthalten sind.
Wieso trifft der Regex?

https://regex101.com/r/wy4DGS/1

Ich hätte folgenden Regex erwartet:
image:\s+(?<depName>cypress\/included):(?<currentValue>.*)@(?<currentDigest>.*)

Siehe:
https://regex101.com/r/GyUiu0/1

@BacLuc
Copy link
Contributor Author

BacLuc commented Nov 12, 2024

Ich sehe, dass es funktioniert. Ich verstehe jedoch nicht wieso.

Das Regex-Pattern enthält ', welche im docker-compose.yml nicht enthalten sind. Wieso trifft der Regex?

https://regex101.com/r/wy4DGS/1

Ich hätte folgenden Regex erwartet: image:\s+(?<depName>cypress\/included):(?<currentValue>.*)@(?<currentDigest>.*)

Siehe: https://regex101.com/r/GyUiu0/1

Ich habe da einen Verdacht....

der sich bestätigt hat.
Wenn man ein normales Image mit digest hat, dann braucht es keine regex.

Siehe bacluc-test-org@5577beb
und bacluc-test-org@edceebf
auf https://github.com/bacluc-test-org/ecamp3/commits/renovate/cypress/
(mein persönlicher fork war schon war schon für andere sachen verwendet)

Because updating them with renovate did not work.
There is anyway only one build with a digest for the
browser versions per build...and they would not be updated under the hood because
that would change the digest too.
@BacLuc BacLuc force-pushed the renovate-update-cypress-again branch from ef66865 to 2a8563a Compare November 12, 2024 21:08
@BacLuc BacLuc changed the title renovate.json: add regex for cypress docker image docker-compose.yml: switch to normal digest to pin browsers for cypress Nov 12, 2024
@BacLuc BacLuc requested a review from a team November 12, 2024 21:10
@BacLuc BacLuc added this pull request to the merge queue Nov 12, 2024
Merged via the queue into ecamp:devel with commit 75b39d7 Nov 12, 2024
35 checks passed
@BacLuc BacLuc deleted the renovate-update-cypress-again branch November 12, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants