Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update regular expression for mdbtools 1.0 output #99

Merged
merged 2 commits into from
Feb 3, 2024

Conversation

chatcannon
Copy link
Collaborator

The output formatting has changed - it now puts multiple data rows in a single INSERT statement, and also changes the quoting of text data.

Fixes #89

The output formatting has changed - it now puts multiple data rows in a
single INSERT statement, and also changes the quoting of text data.
We no longer need to use an old Ubuntu image with old mdbtools version.
@chatcannon
Copy link
Collaborator Author

chatcannon commented Jan 20, 2024

Tests passed with the old mdbtools version used in CI; and also with mdbtools 1.0.0 on ubuntu 22.04

Copy link
Collaborator

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this works for us too, thanks for the fix!

@chatcannon chatcannon merged commit aa0aee6 into echemdata:master Feb 3, 2024
4 checks passed
@chatcannon chatcannon deleted the mdbtools-1-0 branch February 3, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to read res files with mdbtools>=1.0
2 participants