Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing PR in personal fork for ICU-22324 Run code as Java 8 compatible when using JDK 9+ #51

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Testing PR in personal fork for ICU-22324 Run code as Java 8 compatible when using JDK 9+ #51

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edfdd6b
Try custom Maven caching according to Java version
echeran Sep 14, 2023
fb1e402
Temporarily make Maven jobs run on an older GH runner image
echeran Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 25 additions & 6 deletions .github/workflows/icu_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,21 @@ jobs:
fail-fast: false
matrix:
java-version: [ '8', '11', '17' ]
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
steps:
- name: Checkout and setup
uses: actions/checkout@v3
with:
lfs: true
- name: Checkout lfs objects
run: git lfs pull
- name: Cache local Maven repository
uses: actions/cache@v3
with:
path: ~/.m2/repository
key: ${{ runner.os }}-maven-java${{ matrix.java-version }}-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ runner.os }}-maven-java${{ matrix.java-version }}-
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
Expand All @@ -73,7 +80,7 @@ jobs:
# dependencies as jar files
icu4j-test-maven:
name: Run unit tests with Maven for Java version
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
# Make this unit test target job depend on a later phase target job to prevent race condition when
# trying to persist the Maven cache to the Github cache, knowing that artifacts needed for
# the later phase `verify` are a superset of the artifacts needed for the earlier phase `test`.
Expand All @@ -89,11 +96,17 @@ jobs:
lfs: true
- name: Checkout lfs objects
run: git lfs pull
- name: Cache local Maven repository
uses: actions/cache@v3
with:
path: ~/.m2/repository
key: ${{ runner.os }}-maven-java${{ matrix.java-version }}-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ runner.os }}-maven-java${{ matrix.java-version }}-
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: ${{ matrix.java-version }}
cache: maven
- name: Run Maven test
run: |
cd icu4j;
Expand All @@ -102,7 +115,7 @@ jobs:
# Run `verify` to ensure that `package` (creating .jar files) and `integration-test` (special setup for localespi tests) work
icu4j-verify-maven:
name: Run integration tests with Maven for Java version
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
strategy:
fail-fast: false
matrix:
Expand All @@ -114,11 +127,17 @@ jobs:
lfs: true
- name: Checkout lfs objects
run: git lfs pull
- name: Cache local Maven repository
uses: actions/cache@v3
with:
path: ~/.m2/repository
key: ${{ runner.os }}-maven-java${{ matrix.java-version }}-${{ hashFiles('**/pom.xml') }}
restore-keys: |
${{ runner.os }}-maven-java${{ matrix.java-version }}-
- uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: ${{ matrix.java-version }}
cache: maven
# The Maven `verify` phase causes the following to happen first, and in order:
# build/compile (`compile`), unit tests (`test`), Jar building (`package`),
# integration tests, if any (`integration-test`)
Expand All @@ -129,7 +148,7 @@ jobs:

# ICU4J build and unit test under lstm
lstm-icu4j-build-and-test:
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
steps:
- name: Checkout and setup
uses: actions/checkout@v3
Expand Down